[Linux-ha-dev] [PATCH:glue] Correctly locate the logd systemd service file

Discussion:

Kazunori INOUE

2014-06-18 08:57:14 UTC

Hi,

make of cluster-glue fails on RHEL7.

$ cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.0 (Maipo)

$ hg parents
changeset: 2792:45e21bc9795d
tag: tip
user: Dejan Muhamedagic <***@hello-penguin.com>
date: Thu Jun 12 12:28:59 2014 +0200
summary: Low: hb_report: gdb debug symbols output change

$ make rpm
rm -f cluster-glue.tar.bz2
hg archive -t tbz2 -r tip cluster-glue.tar.bz2
echo `date`: Rebuilt cluster-glue.tar.bz2
Wed Jun 18 16:09:36 JST 2014: Rebuilt cluster-glue.tar.bz2
rm -f *.src.rpm
To create custom builds, edit the flags and options in
cluster-glue-fedora.spec first
rpmbuild -bs --define "dist .fedora" --define "_sourcedir
/zzz/DEV/glue" --define "_specdir /zzz/DEV/glue" --define "_srcrpmdir
/zzz/DEV/glue" cluster-glue-fedora.spec
Wrote: /zzz/DEV/glue/cluster-glue-1.0.12-0.rc1.fedora.src.rpm
rpmbuild --define "_sourcedir /zzz/DEV/glue" --define "_specdir
/zzz/DEV/glue" --define "_srcrpmdir /zzz/DEV/glue" --rebuild
/zzz/DEV/glue/*.src.rpm
Installing /zzz/DEV/glue/cluster-glue-1.0.12-0.rc1.fedora.src.rpm
(snip)
+ /usr/lib/rpm/redhat/brp-java-repack-jars
Processing files: cluster-glue-1.0.12-0.rc1.el7.x86_64
error: File not found:
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/etc/init.d/logd
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.kJSlFu
+ umask 022
+ cd /root/rpmbuild/BUILD
+ cd cluster-glue
+ DOCDIR=/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ export DOCDIR
+ /usr/bin/mkdir -p
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr doc/stonith/README.bladehpi doc/stonith/README.cyclades
doc/stonith/README.drac3 doc/stonith/README.dracmc
doc/stonith/README.external doc/stonith/README.ibmrsa
doc/stonith/README.ibmrsa-telnet doc/stonith/README.ipmilan
doc/stonith/README.ippower9258 doc/stonith/README.meatware
doc/stonith/README.rackpdu doc/stonith/README.rcd_serial
doc/stonith/README.riloe doc/stonith/README.vacm
doc/stonith/README.vcenter doc/stonith/README.wti_mpc
doc/stonith/README_kdumpcheck.txt
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr logd/logd.cf
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr AUTHORS
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr COPYING
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr ChangeLog
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ exit 0

RPM build errors:
File not found:
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/etc/init.d/logd
make: *** [rpm] Error 1
$

Dejan Muhamedagic

2014-06-18 19:30:10 UTC

Permalink

Hi Kazunori-san,

Post by Kazunori INOUE
Hi,
make of cluster-glue fails on RHEL7.
$ cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.0 (Maipo)
$ hg parents
changeset: 2792:45e21bc9795d
tag: tip
date: Thu Jun 12 12:28:59 2014 +0200
summary: Low: hb_report: gdb debug symbols output change
$ make rpm
rm -f cluster-glue.tar.bz2
hg archive -t tbz2 -r tip cluster-glue.tar.bz2
echo `date`: Rebuilt cluster-glue.tar.bz2
Wed Jun 18 16:09:36 JST 2014: Rebuilt cluster-glue.tar.bz2
rm -f *.src.rpm
To create custom builds, edit the flags and options in
cluster-glue-fedora.spec first
rpmbuild -bs --define "dist .fedora" --define "_sourcedir
/zzz/DEV/glue" --define "_specdir /zzz/DEV/glue" --define "_srcrpmdir
/zzz/DEV/glue" cluster-glue-fedora.spec
Wrote: /zzz/DEV/glue/cluster-glue-1.0.12-0.rc1.fedora.src.rpm
rpmbuild --define "_sourcedir /zzz/DEV/glue" --define "_specdir
/zzz/DEV/glue" --define "_srcrpmdir /zzz/DEV/glue" --rebuild
/zzz/DEV/glue/*.src.rpm
Installing /zzz/DEV/glue/cluster-glue-1.0.12-0.rc1.fedora.src.rpm
(snip)
+ /usr/lib/rpm/redhat/brp-java-repack-jars
Processing files: cluster-glue-1.0.12-0.rc1.el7.x86_64
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/etc/init.d/logd

Yes, unfortunately the systemd support was added without adding
support to the spec files. I'm not an expert on these, so I'd
like to ask you to test the patch I put together. If you could
also fix any problems you run into, that'd be great.

Cheers,

Dejan

Post by Kazunori INOUE
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.kJSlFu
+ umask 022
+ cd /root/rpmbuild/BUILD
+ cd cluster-glue
+ DOCDIR=/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ export DOCDIR
+ /usr/bin/mkdir -p
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr doc/stonith/README.bladehpi doc/stonith/README.cyclades
doc/stonith/README.drac3 doc/stonith/README.dracmc
doc/stonith/README.external doc/stonith/README.ibmrsa
doc/stonith/README.ibmrsa-telnet doc/stonith/README.ipmilan
doc/stonith/README.ippower9258 doc/stonith/README.meatware
doc/stonith/README.rackpdu doc/stonith/README.rcd_serial
doc/stonith/README.riloe doc/stonith/README.vacm
doc/stonith/README.vcenter doc/stonith/README.wti_mpc
doc/stonith/README_kdumpcheck.txt
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr logd/logd.cf
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr AUTHORS
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr COPYING
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ cp -pr ChangeLog
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/usr/share/doc/cluster-glue-1.0.12
+ exit 0
/root/rpmbuild/BUILDROOT/cluster-glue-1.0.12-0.rc1.fedora.x86_64/etc/init.d/logd
make: *** [rpm] Error 1
$
_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Kazunori INOUE

2014-06-19 05:04:45 UTC

Permalink

Hi Dejan,

Post by Dejan Muhamedagic
Hi Kazunori-san,

Since RHEL didn't have the following macro, it corrected.
- service_add_post
- service_del_preun
- service_del_postun
- service_add_pre : since the macro corresponding to service_add_pre
was not found, it deleted. (quick fix)

$ rpm -qp --scripts
/root/rpmbuild/RPMS/x86_64/cluster-glue-1.0.12-0.rc1.el7.x86_64.rpm
preinstall scriptlet (using /bin/sh):
getent group haclient >/dev/null || groupadd -r haclient
getent passwd hacluster >/dev/null || \
useradd -r -g haclient -d /var/lib/heartbeat/cores/hacluster -s /sbin/nologin \
-c "cluster user" hacluster
%service_add_pre logd.service
exit 0
postinstall scriptlet (using /bin/sh):
%service_add_post logd.service
preuninstall scriptlet (using /bin/sh):
%service_del_preun logd.service
postuninstall scriptlet (using /bin/sh):
%service_del_postun logd.service

$ rpm -ivh cluster-glue-1.0.12-0.rc1.el7.x86_64.rpm
Preparing... ################################# [100%]
/var/tmp/rpm-tmp.88IU8v: line 5: fg: no job control
Updating / installing...
1:cluster-glue-1.0.12-0.rc1.el7 ################################# [100%]
/var/tmp/rpm-tmp.d0hXL3: line 1: fg: no job control
warning: %post(cluster-glue-1.0.12-0.rc1.el7.x86_64) scriptlet failed,
exit status 1
$ rpm -e cluster-glue
/var/tmp/rpm-tmp.dT37S2: line 1: fg: no job control
error: %preun(cluster-glue-1.0.12-0.rc1.el7.x86_64) scriptlet failed,
exit status 1
error: cluster-glue-1.0.12-0.rc1.el7.x86_64: erase failed

And I have no SUSE environment now, so suse.spec is not checking.

Regards,

Post by Dejan Muhamedagic
Cheers,
Dejan

_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Dejan Muhamedagic

2014-06-23 08:36:02 UTC

Permalink

Post by Kazunori INOUE
Hi Dejan,

Post by Dejan Muhamedagic
Hi Kazunori-san,

Since RHEL didn't have the following macro, it corrected.
- service_add_post
- service_del_preun
- service_del_postun
- service_add_pre : since the macro corresponding to service_add_pre
was not found, it deleted. (quick fix)
$ rpm -qp --scripts
/root/rpmbuild/RPMS/x86_64/cluster-glue-1.0.12-0.rc1.el7.x86_64.rpm
getent group haclient >/dev/null || groupadd -r haclient
getent passwd hacluster >/dev/null || \
useradd -r -g haclient -d /var/lib/heartbeat/cores/hacluster -s /sbin/nologin \
-c "cluster user" hacluster
%service_add_pre logd.service
exit 0
%service_add_post logd.service
%service_del_preun logd.service
%service_del_postun logd.service
$ rpm -ivh cluster-glue-1.0.12-0.rc1.el7.x86_64.rpm
Preparing... ################################# [100%]
/var/tmp/rpm-tmp.88IU8v: line 5: fg: no job control
Updating / installing...
1:cluster-glue-1.0.12-0.rc1.el7 ################################# [100%]
/var/tmp/rpm-tmp.d0hXL3: line 1: fg: no job control
warning: %post(cluster-glue-1.0.12-0.rc1.el7.x86_64) scriptlet failed,
exit status 1
$ rpm -e cluster-glue
/var/tmp/rpm-tmp.dT37S2: line 1: fg: no job control
error: %preun(cluster-glue-1.0.12-0.rc1.el7.x86_64) scriptlet failed,
exit status 1
error: cluster-glue-1.0.12-0.rc1.el7.x86_64: erase failed
And I have no SUSE environment now, so suse.spec is not checking.

Many thanks for the fedora spec file. I think I managed to fix
the suse spec file, at least it manages to produce a package with
openSUSE Factory. Both patches pushed.

Cheers,

Dejan

Post by Kazunori INOUE
Regards,

Post by Dejan Muhamedagic
Cheers,
Dejan

_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/