[Linux-ha-dev] [PATCH] Refine jboss RA functions about console logfile rotation

Discussion:

NAKAHIRA Kazutomo

2013-10-04 12:11:20 UTC

Hi, all

I wrote 8 pathces for jboss RA that refine jboss RA functions
about console logfile rotation.
(some patches were written for current code refactoring.)

Please see following pull requests and comment me
if you have a any question.

1. Low: jboss: Refine validate_all_jboss(It checks JAVA_HOME,
JBOSS_HOME, and JAVA)

https://github.com/knakahira/resource-agents/commit/5024ede722c337f273f30f852369cc386d1369b9

2. Low: jboss: Check JBOSS_BASE_DIR at the validate_all_jboss

https://github.com/knakahira/resource-agents/commit/562ab655398b9bbbf6e0a722d61f01cd45b5409c

3. Low: jboss: Check ROTATELOGS command at the validate_all_jboss

https://github.com/knakahira/resource-agents/commit/90122d3d24020c3caa5e504bf22e68d8364bd0af

4. Low: jboss: Avoid starting JBoss without rotatelogs when
rotate_console is true

https://github.com/knakahira/resource-agents/commit/988ba56520625fc11f83f40c12afb28fc0655e1f

5. Low: jboss: Monitor rotatelogs process and restart when it is stopped

https://github.com/knakahira/resource-agents/commit/83fe1937360b720115403baf787f39532378247c

6. Low: jboss: Avoid overwriting the existing CONSOLE logfile when
rotate_console was changed

https://github.com/knakahira/resource-agents/commit/bf3b3075bda37aa068cce206f8de665b89d3866c

7. Low: jboss: Change test command operator "=" to "-eq" at numerical
comparison

https://github.com/knakahira/resource-agents/commit/534b4bc299232e5feb8f133a247e8334402f92e5

8. Low: jboss: Avoid starting JBoss if $JBOSS_USER can not write CONSOLE
logfile that created by rotatelogs command

https://github.com/knakahira/resource-agents/commit/62588ae50408f6897452dedbeb0b1074a5ca4c26

Best regards,

--
NAKAHIRA Kazutomo
Open Source Business Unit
NTT DATA INTELLILINK Corporation

Dejan Muhamedagic

2013-10-07 09:24:45 UTC

Permalink

Hi Kazutomo-san,

Post by NAKAHIRA Kazutomo
Hi, all
I wrote 8 pathces for jboss RA that refine jboss RA functions
about console logfile rotation.
(some patches were written for current code refactoring.)
Please see following pull requests and comment me

These are not pull requests, but commits in your repository. You
should create one or more pull requests for the upstream. We're
currently about to make a new release, so unless there are bug
fixes or new features, they will have to wait until after the
release.

Cheers,

Dejan

Post by NAKAHIRA Kazutomo
if you have a any question.
1. Low: jboss: Refine validate_all_jboss(It checks JAVA_HOME,
JBOSS_HOME, and JAVA)
https://github.com/knakahira/resource-agents/commit/5024ede722c337f273f30f852369cc386d1369b9
2. Low: jboss: Check JBOSS_BASE_DIR at the validate_all_jboss
https://github.com/knakahira/resource-agents/commit/562ab655398b9bbbf6e0a722d61f01cd45b5409c
3. Low: jboss: Check ROTATELOGS command at the validate_all_jboss
https://github.com/knakahira/resource-agents/commit/90122d3d24020c3caa5e504bf22e68d8364bd0af
4. Low: jboss: Avoid starting JBoss without rotatelogs when
rotate_console is true
https://github.com/knakahira/resource-agents/commit/988ba56520625fc11f83f40c12afb28fc0655e1f
5. Low: jboss: Monitor rotatelogs process and restart when it is stopped
https://github.com/knakahira/resource-agents/commit/83fe1937360b720115403baf787f39532378247c
6. Low: jboss: Avoid overwriting the existing CONSOLE logfile when
rotate_console was changed
https://github.com/knakahira/resource-agents/commit/bf3b3075bda37aa068cce206f8de665b89d3866c
7. Low: jboss: Change test command operator "=" to "-eq" at numerical
comparison
https://github.com/knakahira/resource-agents/commit/534b4bc299232e5feb8f133a247e8334402f92e5
8. Low: jboss: Avoid starting JBoss if $JBOSS_USER can not write CONSOLE
logfile that created by rotatelogs command
https://github.com/knakahira/resource-agents/commit/62588ae50408f6897452dedbeb0b1074a5ca4c26
Best regards,
--
NAKAHIRA Kazutomo
Open Source Business Unit
NTT DATA INTELLILINK Corporation
_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

NAKAHIRA Kazutomo

2013-10-08 01:17:45 UTC

Permalink

Hi, Dejan

Sorry for a written mistake "pull requests".
There are pathces need a review.

And I made a pull request about these patches.

https://github.com/ClusterLabs/resource-agents/pull/327

Best regards,

Post by Dejan Muhamedagic
Hi Kazutomo-san,

_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

--
NAKAHIRA Kazutomo
Open Source Business Unit
NTT DATA INTELLILINK Corporation