Discussion:
[Linux-ha-dev] [Patch]Exit code of reset of external/libvirt is wrong.
r***@ybb.ne.jp
2013-07-04 23:51:14 UTC
Permalink
Hi All,

The exit code of reset of external/libvirt is wrong.
I attached a patch.

Best Regards,
Hideo Yamauchi.
Dejan Muhamedagic
2013-07-05 08:40:46 UTC
Permalink
Hi Hideo-san,
Post by r***@ybb.ne.jp
Hi All,
The exit code of reset of external/libvirt is wrong.
Indeed. Quite sloppy the latest change, my apologies.
Post by r***@ybb.ne.jp
I attached a patch.
Many thanks for the patch. Applied (slightly modified).
I wonder if we should also ignore the outcome of libvirt_start.
What are the chances that it fails?

Cheers,

Dejan
Post by r***@ybb.ne.jp
Best Regards,
Hideo Yamauchi.
_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
r***@ybb.ne.jp
2013-07-05 20:37:25 UTC
Permalink
Hi Dejan,

Thank you for comments.
Post by Dejan Muhamedagic
Many thanks for the patch. Applied (slightly modified).
I wonder if we should also ignore the outcome of libvirt_start.
What are the chances that it fails?
I found that I failed in libvirt_start for the first time.
When I use libvirt in vSphere environment, it occurs.
In the vSphere environment, libvirt can carry out libvirt_stop of the fail over host of the vSphere HA, but cannot carry out libvirt_start.
Probably I think that it is a problem not to happen in KVM.

Best Regards,
Hideo Yamauchi.
Post by Dejan Muhamedagic
Hi Hideo-san,
Post by r***@ybb.ne.jp
Hi All,
The exit code of reset of external/libvirt is wrong.
Indeed. Quite sloppy the latest change, my apologies.
Post by r***@ybb.ne.jp
I attached a patch.
Many thanks for the patch. Applied (slightly modified).
I wonder if we should also ignore the outcome of libvirt_start.
What are the chances that it fails?
Cheers,
Dejan
Post by r***@ybb.ne.jp
Best Regards,
Hideo Yamauchi.
_______________________________________________________
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
Loading...