Discussion:
[Linux-ha-dev] pull request for sg_persist new RA & ocft
Liuhua Wang
2014-03-18 08:24:51 UTC
Permalink
Hi, list

I have added a new resource agent(sg_persist) and pulled request to Github:
https://github.com/ClusterLabs/resource-agents/pull/372

It is a Resource agent that implements SPC-3 Persistent
Reservations, originally contributed from Evgeny Nifontov.
(Sorry, I don't have his email)

The sg_persist RA is just based on the sg3_utils tools(sg_persist).
It works as a Master/Slave resource. It registers a reservation key
for devices when the resource starts and holds reservation
when the resource promotes to be a Master.

I did plenty of tests to verify it, and add some codes to
support multi-masters in case of the reservation type is 7/8.
I also added the ocft test script for automatic test.


It will be very helpful if anybody has time to review and give commits.
Thank you very much:)

Best regards,
Liuhua Wang (email:***@suse.com)
Lars Marowsky-Bree
2014-03-21 15:44:53 UTC
Permalink
On 2014-03-18T02:24:51, Liuhua Wang <***@suse.com> wrote:

Hi Liuhua,

thanks for pushing again!

I've taken some time to provide some code review. Overall, I think it
looks good, mostly cosmetic and codingstyle.

I'd welcome more insight from others on this list; especially those with
maintainer access to github's resource-agents repository ;-)


Regards,
Lars
--
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde
Loading...